Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default export to avoid Webpack 5 warning #45

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 3, 2022

Description of proposed changes

In Webpack 5, named exports from JSON modules are no longer supported¹.

This is in anticipation of Auspice using Webpack 5 in a future release, but it should be compatible with the current release.

¹ https://webpack.js.org/migrate/5/#using-named-exports-from-json-modules

Related issue(s)

Testing

  • Preview app loads

In Webpack 5, named exports from JSON modules are no longer supported¹.

This is in anticipation of Auspice using Webpack 5 in a future release,
but it should be compatible with the current release.

¹ https://webpack.js.org/migrate/5/#using-named-exports-from-json-modules
@victorlin victorlin requested a review from a team December 3, 2022 05:15
@victorlin victorlin self-assigned this Dec 3, 2022
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-us-victorlin-us-9zuyt8 December 3, 2022 05:15 Inactive
@jameshadfield jameshadfield merged commit 4fbf76c into master Dec 6, 2022
@jameshadfield jameshadfield deleted the victorlin/use-default-export branch December 6, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants